This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Move the responsibility to pick an input log from storage to the frontend #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pav-kv
reviewed
Nov 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #1376 +/- ##
=========================================
+ Coverage 65.41% 65.72% +0.3%
=========================================
Files 51 51
Lines 3909 3909
=========================================
+ Hits 2557 2569 +12
+ Misses 956 949 -7
+ Partials 396 391 -5
Continue to review full report at Codecov.
|
gdbelvin
changed the title
mhutchinson
reviewed
Nov 6, 2019
mhutchinson
approved these changes
Nov 6, 2019
pav-kv
reviewed
Nov 6, 2019
| } | ||
|
|
||
| func (m *mutations) ListLogs(ctx context.Context, dirID string, _ bool) ([]int64, error) { | ||
| logIDs := []int64{} |
There was a problem hiding this comment.
Could pre-allocate len(*m) items here.
pav-kv
reviewed
Nov 6, 2019
| @@ -666,6 +674,18 @@ func (s *Server) BatchQueueUserUpdate(ctx context.Context, in *pb.BatchQueueUser | |||
| return &empty.Empty{}, nil | |||
| } | |||
|
|
|||
| func (s *Server) randLog(ctx context.Context, directoryID string) (int64, error) { | |||
| // TODO(gbelvin): Cache these results. | |||
There was a problem hiding this comment.
How badly does this read harm the write performance?
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Nov 13, 2019
* master: Define watermarks as micros (google#1384) Library for converting time.Time to sequencer watermarks (google#1381) Reduce log spam (google#1382) Support and test mutation log queries at intermediate timestamps (google#1380) In memory logs implementation (google#1375) Fix generic comparisons on protobuf messages (google#1379) Do pagination the right way (google#1378) Move the responsibility to pick an input log from storage to the frontend (google#1376) Init metrics for whole test file (google#1373) Break layering violation by using native types (google#1374) Switch Timestamp storage to mysql DATETIME (google#1369) Use testdb in integration tests (google#1371)
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Dec 10, 2019
* master: (22 commits) Enable travis build validation (google#1400) Use ProtoEqual for gomock reflection equality (google#1401) Fixups for deleted test constructor in trillian repo (google#1398) Fix the kubernetes configs (google#1397) Upgrade dependencies (google#1387) Update install instructions for go 1.13 (google#1388) Emit metric with the right dimensions (google#1383) Define watermarks as micros (google#1384) Library for converting time.Time to sequencer watermarks (google#1381) Reduce log spam (google#1382) Support and test mutation log queries at intermediate timestamps (google#1380) In memory logs implementation (google#1375) Fix generic comparisons on protobuf messages (google#1379) Do pagination the right way (google#1378) Move the responsibility to pick an input log from storage to the frontend (google#1376) Init metrics for whole test file (google#1373) Break layering violation by using native types (google#1374) Switch Timestamp storage to mysql DATETIME (google#1369) Use testdb in integration tests (google#1371) Use and test the same MySQL connection that main.go uses (google#1370) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow clients to specify the mutation input log
This permits quality of service prioritization because
input logs are processed in low to high order.